Trace tool #1723
Trace tool #1723
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
facebook-github-bot
added
the
CLA Signed
|
@horizon-blue I am working on updating the notebook to mdx converter based on the revisions in this PR. I think this tool would be the first to merge as it directly updates (no change to prose) the coin flipping tutorial by adding it to the tutorial. |
|
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@horizon-blue that's spectacular! I don't have a use case for PR #1691 yet, but do in this one which is why I suggested merging this first. But, I think if you can merge #1691 then I'll remove the [WIP] flag, and I can keep building from there. |
|
:) Finally merged #1691 after it pass the internal tests. However, it looks like we have to resolve quite a bit of merge conflicts before I can test out this PR. Also, just as a FYI, I changed the diagnostic accessor a bit. It now lazily imports the widgets only when necessary. That way we don't have to add Bokeh and IPython to our core dependencies. |
|
@ndmlny-qs has updated the pull request. You must reimport the pull request before landing. |
|
I took the liberty to resolve the merge conflicts with the marginal 1D tool so I can show both widgets in a single notebook. Hopefully I didn't break anything during the merge (the widget looks fine on my local jupyter session, though I still need to try it out to tell if it works in Bento. |
|
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@ndmlny-qs has updated the pull request. You must reimport the pull request before landing. |
horizon-blue
force-pushed
the
trace-tool
branch
from
967f79e
to
a57437b
Compare
|
@ndmlny-qs has updated the pull request. You must reimport the pull request before landing. |
|
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
fbcode/beanmachine/beanmachine/ppl/diagnostics/tools/js/src/stats/histogram.ts |
|
@ndmlny-qs has updated the pull request. You must reimport the pull request before landing. |
|
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Looks like we need to resolve the merge conflict on the Coin flipping tutorial again :). Can we also make sure that it's up-to-date? Looks like there're some changes in the trace plot widget that's not reflected in the tutorial. |
This commit includes the marginal 1D diagnostic tool with JavaScript callbacks.
- Removes ArviZ as a dependency from the diagnostic tool. - Adds jsdoc Documentation for the TypeScript methods. - Fixes flake8 linting error. - Adds clarifying comments to the tool. - Adds missing copyright notice.
- Aligns type names between Python and TypeScript. There is now a one-to-one correspondence between Python TypedDict objects and the TypeScript interface objects. - Redundancy in the Python TypedDict objects has been removed. - Fixes tooltips not rendering correctly. - Updates the link in the Help Tab of the tool such that when clicked it opens a new tab in the browser. - Moves a few peerDependencies to the devDependencies section in the package.json file. This was done because yarn issued a warning indicating there were missing peer dependencies. - Refactors the tool such that no calculations for the data displayed is done in Python. All updates and all calculations for the tool data is done exclusively in the browser. The rational for this change was to prevent users from having initial data calculated by Python, and subsequent updates calculated by JavaScript in the browser when interacting with the tool. There are notes in the code indicating why this change was made.
This tool branches from the marginal1d tool and rebases against main. Added files include those needed for displaying a Trace diagnostic tool for Bean Machine models. This also updates the Coin_flipping.ipynb tutorial to include the new diagnostic tool.
- Rebased against `main`, and fixed merged conflicts. - Updated copyright requirement - Updated how models are serialized. - Update style based on other pushes to the branch - Added `__future__` annotations - updated a few docstrings that needed an update - updated yarn lock based on changes with the marginal1d tool and the trace tool. - removed the 3rd party histogram requirement, since it is easy to calculate a histogram. - other fixes associated with merging etc.
|
@ndmlny-qs has updated the pull request. You must reimport the pull request before landing. |
|
I rebased, fixed merge conflicts, and made sure coin flipping tutorial was the one already in the main branch. Let me know if there are any other problems I should address with this PR. |
|
@horizon-blue has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Motivation
Continued work on the diagnostics tool, this includes a model trace tool.
Changes proposed
Test Plan
The tool was run in the Coin flipping tutorial.
Types of changes
Checklist